xfree86: device parser fix crash with duplicate "Clocks" property #1416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #1407
This commit fixes when processing the first line, the clock frequency value ptr->dev_clocks is 0. If the first line of the clock frequency contains 100 values, the clock frequency value ptr->dev_clocks will be 100. When processing the second row "Clocks", which contains, for example, 100 more values, the loop will start with i = 100. This will cause 72 values to be written outside the 128-element dev_block array, which will lead to buffer overflow and an emergency crash xserver.